Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

ayman
Hi compiled Nginx 1.13.9 from master branch to try out HTTP/2 Server Push
but noticed the pushed assets loose their gzip compression and are served as
non-compressed assets ? Is that as intended ? I posted my findings at
https://community.centminmod.com/threads/hurray-http-2-server-push-for-nginx.11910/#post-59411

    http2_push_preload on;
    add_header Link "</css/bootstrap.min.css>; rel=preload; as=style";
    add_header Link "</css/theme-style.css>; rel=preload; as=style";

push works as I see PUSH_PROMISE frames and chrome reports push

nghttp -navs https://baremetal.doman.com/

[  0.018] recv (stream_id=13) :method: GET
[  0.018] recv (stream_id=13) :path: /css/bootstrap.min.css
[  0.018] recv (stream_id=13) :authority: baremetal.domain.com
[  0.018] recv (stream_id=13) :scheme: https
[  0.018] recv PUSH_PROMISE frame <length=42, flags=0x04, stream_id=13>
          ; END_HEADERS
          (padlen=0, promised_stream_id=2)
[  0.018] recv (stream_id=13) :method: GET
[  0.018] recv (stream_id=13) :path: /css/theme-style.css
[  0.018] recv (stream_id=13) :authority: baremetal.domain.com
[  0.018] recv (stream_id=13) :scheme: https
[  0.018] recv PUSH_PROMISE frame <length=40, flags=0x04, stream_id=13>

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278481,278481#msg-278481

_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

ayman
Reported bug at https://trac.nginx.org/nginx/ticket/1478

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278481,278488#msg-278488

_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

Ruslan Ermilov
On Sat, Feb 10, 2018 at 01:21:16PM -0500, George wrote:

> Hi compiled Nginx 1.13.9 from master branch to try out HTTP/2 Server Push
> but noticed the pushed assets loose their gzip compression and are served as
> non-compressed assets ? Is that as intended ? I posted my findings at
> https://community.centminmod.com/threads/hurray-http-2-server-push-for-nginx.11910/#post-59411
>
>     http2_push_preload on;
>     add_header Link "</css/bootstrap.min.css>; rel=preload; as=style";
>     add_header Link "</css/theme-style.css>; rel=preload; as=style";
>
> push works as I see PUSH_PROMISE frames and chrome reports push
>
> nghttp -navs https://baremetal.doman.com/
>
> [  0.018] recv (stream_id=13) :method: GET
> [  0.018] recv (stream_id=13) :path: /css/bootstrap.min.css
> [  0.018] recv (stream_id=13) :authority: baremetal.domain.com
> [  0.018] recv (stream_id=13) :scheme: https
> [  0.018] recv PUSH_PROMISE frame <length=42, flags=0x04, stream_id=13>
>           ; END_HEADERS
>           (padlen=0, promised_stream_id=2)
> [  0.018] recv (stream_id=13) :method: GET
> [  0.018] recv (stream_id=13) :path: /css/theme-style.css
> [  0.018] recv (stream_id=13) :authority: baremetal.domain.com
> [  0.018] recv (stream_id=13) :scheme: https
> [  0.018] recv PUSH_PROMISE frame <length=40, flags=0x04, stream_id=13>

On Sun, Feb 11, 2018 at 04:16:05PM -0500, George wrote:
> Reported bug at https://trac.nginx.org/nginx/ticket/1478

The fix is underway.
_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

ayman
thanks Ruslan for the update appreciate all your work and looking forward to
playing with HTTP/2 Push finally ! :)

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278481,278582#msg-278582

_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

Ruslan Ermilov
On Wed, Feb 14, 2018 at 06:19:01PM -0500, George wrote:
> thanks Ruslan for the update appreciate all your work and looking forward to
> playing with HTTP/2 Push finally ! :)

Start off right today:
https://www.youtube.com/watch?v=wR1gF5Lhcq0
_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

ayman
Thanks for that video link :)

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278481,278585#msg-278585

_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx
Reply | Threaded
Open this post in threaded view
|

Re: Nginx 1.13.9 HTTP/2 Server Push - non-compressed assets ?

ayman
In reply to this post by ayman
thanks Ruslan just tested your committed fixes for this in master branch and
working nicely
https://community.centminmod.com/threads/hurray-http-2-server-push-for-nginx.11910/page-2#post-59602
:)

Posted at Nginx Forum: https://forum.nginx.org/read.php?2,278481,278608#msg-278608

_______________________________________________
nginx mailing list
[hidden email]
http://mailman.nginx.org/mailman/listinfo/nginx